FakeFs impl #34
corigan01
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
1 error and 5 warnings
|
build
Process completed with exit code 101.
|
|
using `clone` on type `LinearFramebuffer` which implements the `Copy` trait:
src/main.rs#L154
warning: using `clone` on type `LinearFramebuffer` which implements the `Copy` trait
--> src/main.rs:154:27
|
154 | let mut framebuffer = boot_info.framebuffer.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `boot_info.framebuffer`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
this operation has no effect:
src/main.rs#L104
warning: this operation has no effect
--> src/main.rs:104:44
|
104 | let init_alloc_size = HumanBytes::from(1 * HumanBytes::MIB) - 2.into();
| ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `HumanBytes::MIB`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
this import is redundant:
src/main.rs#L52
warning: this import is redundant
--> src/main.rs:52:1
|
52 | use fs;
| ^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
|
manual implementation of an assign operation:
src/clock/rtc.rs#L130
warning: manual implementation of an assign operation
--> src/clock/rtc.rs:130:9
|
130 | current_rtc_time.hour = current_rtc_time.hour % 24;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_rtc_time.hour %= 24`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
|
|
you should consider adding a `Default` implementation for `RealTimeClock`:
src/clock/rtc.rs#L59
warning: you should consider adding a `Default` implementation for `RealTimeClock`
--> src/clock/rtc.rs:59:5
|
59 | / pub fn new() -> Self {
60 | | Self {
61 | | time: Time::new(),
62 | | time_zone_modification: 0,
63 | | }
64 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
55 + impl Default for RealTimeClock {
56 + fn default() -> Self {
57 + Self::new()
58 + }
59 + }
|
|