Show terminal warning only when user did not enter arguments. #1120
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the user clicked the `.exe`. If there are arguments, assume the user knows what they're doing. Add some launch tasks in `.vscode` to demonstrate the difference.
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
|
Would be great if this could get reviewed and merged 👍 |
|
This PR is stale because it has been open 45 days with no activity. |
|
Can this be reviewed/merged? Currently blocking my Jenkins2 pipelines |
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1068
(doesn't fix the underlying terminal check, but limits the issue to users who didn't enter any
nvmcommand)Only check terminal when there are no arguments, because it's possible the user clicked the
.exe. If there are arguments, assume the user knows what they're doing. Add some launch tasks in.vscodeto demonstrate the difference. The warning now indicates that if you are in an unsupported terminal, to try runningnvm helpinstead.Feel free to remove
.vscode/launch.jsonif you do not use VS Code. I used it to create an example of:nvmwithout commands in debug console -- opens warning indicatingnvmcan only be run in a terminalnvmin external console (like command prompt) -- prints normal help message in terminalnvm versionin debug console -- works normally