Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: globally allow all webdav methods #109

Merged
merged 12 commits into from
Jan 22, 2025

Conversation

EsadCetiner
Copy link
Member

Nextcloud makes very heavy use of WebDAV methods, it's pretty much used everywhere even in the Web GUI. So much so about 1/3 of all rules were solely for allowing WebDAV methods. Now with this refactor, these methods are allowed globally within the plugin. This should be an big improvement in terms of maintenance and usability for the plugin.

I didn't test this for very long as existing test coverage should pick up any regressions, and this refactor is relatively simple.

  • Reduced the number of lines of code by about 700.
  • Number of rules has gone down from 169 to 103.
  • A nice bonus is that some unsupported Nextcloud Apps may now be usable for more basic use cases at PL-1.
  • The plugin will require significantly less maintenance in the long run, adding support for additional apps in the future will be easier too.
  • Fixes a few false positives in supported apps thanks to the refactor.

Co-authored-by: Max Leske <[email protected]>
@EsadCetiner EsadCetiner merged commit 03caa72 into coreruleset:main Jan 22, 2025
3 checks passed
@EsadCetiner EsadCetiner deleted the refactor-allow-dav-methods branch January 22, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants