refactor: globally allow all webdav methods #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextcloud makes very heavy use of WebDAV methods, it's pretty much used everywhere even in the Web GUI. So much so about 1/3 of all rules were solely for allowing WebDAV methods. Now with this refactor, these methods are allowed globally within the plugin. This should be an big improvement in terms of maintenance and usability for the plugin.
I didn't test this for very long as existing test coverage should pick up any regressions, and this refactor is relatively simple.