Updated Nginx Dockerfile for MaximDB support #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added maximDB support to dockerfile for OWASP CRS 4.5 Nginx Image
Dr-Lazarus-V2
changed the title
airween
approved these changes
Sep 17, 2024
|
Do you mind doing the same for the https://github.com/coreruleset/modsecurity-crs-docker/blob/main/nginx/Dockerfile-alpine and https://github.com/coreruleset/modsecurity-crs-docker/blob/main/openresty/Dockerfile-alpine? Package names might have a slightly different naming, so check https://pkgs.alpinelinux.org/packages first. Thanks! |
Added --with-maxmind flag, libmaxminddb-dev is already present.
Added --with-maxmind flag, libmaxminddb-dev already present
|
I have updated the files with the flag: --with-maxmind. The libmaxminddb-dev appears to be present in them. |
|
Looks good, thanks. Let's see if tests pass. |
fzipi
approved these changes
Sep 19, 2024
|
Thanks @Dr-Lazarus-V2 for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added maximDB support to dockerfile for OWASP CRS 4.5 Nginx Image