Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: error if port or ssl_port are lower than 1024 #235

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Apr 24, 2024

what

  • do not start container if port or ssl_port are defined lower than 1024

why

after moving to unprivileged containers, people might not have updated their setups, bringing problems when starting

@fzipi fzipi requested a review from theseion April 24, 2024 03:08
apache/docker-entrypoint.sh Outdated Show resolved Hide resolved
@fzipi
Copy link
Member Author

fzipi commented Apr 24, 2024

Maybe moving this to a file instead so it can be included in both servers.

@fzipi fzipi marked this pull request as ready for review April 24, 2024 18:49
@fzipi fzipi merged commit f5cd07b into develop Apr 24, 2024
6 checks passed
@fzipi fzipi deleted the error-low-port branch April 24, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants