Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PR checks for windows #350

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

jabdr
Copy link
Contributor

@jabdr jabdr commented Aug 25, 2024

This should run the github actions for testing the code for both linux and windows.

This should be merged after #348

See #349

Copy link
Collaborator

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theseion
Copy link
Collaborator

@jabdr Please consider setting up commit signing. We generally require commits to be signed.

@theseion theseion merged commit 4fc14cf into coreruleset:main Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants