feat: restructure; update naming pattern and weight; fix inner-link #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xhoenix
reviewed
Oct 12, 2024
|
Hi @dextermallo ! Can you rebase your changes? |
dextermallo
force-pushed
the
feat/restructure-hierarchy
branch
from
419494c
to
0f7a705
Compare
Done in 0f7a705. Also fix an image-link error :) |
theseion
requested changes
Nov 8, 2024
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| title: Plugin Mechanism | |||
| weight: 40 | |||
| title: What is Plugin | |||
There was a problem hiding this comment.
Suggested change
| title: What is Plugin | |
| title: Plugins |
There was a problem hiding this comment.
Fixed in 53a0433
content/5-advanced-usages/_index.md
Outdated
| title: Miscellaneous | ||
| weight: 70 | ||
| pre: "<b>7. </b>" | ||
| title: Advanced Usages |
There was a problem hiding this comment.
Suggested change
| title: Advanced Usages | |
| title: Advanced Topics |
There was a problem hiding this comment.
Fixed in 53a0433
content/7-known-issues/_index.md
Outdated
| @@ -1,8 +1,8 @@ | |||
| --- | |||
| title: Known Issues | |||
| weight: 10 | |||
| title: 7. Known Issues | |||
There was a problem hiding this comment.
Fixed in 53a0433
…les (coreruleset#146) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…set#140) * chore(deps): pin dependencies in .github/workflows/test.yml * fix: use user agent that isn't blocked by drupal / sourceforge --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Max Leske <[email protected]>
|
Hmm not sure what bumped into my PR; every time I rebase, the PR reverts some of my previous changes. (The conflicts I saw in the PR should not be existed since the files are renamed and moved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement #133
Further comments