fix: restrict use of evasion modifiers to end of line #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint seems broken? |
|
Yeah, ignore that. I opened another commit that removes mage and fixes the failures. |
fzipi
approved these changes
Jan 2, 2025
Until now, `~` and `@` would be replaced by the evasion suffix regardless of their position in the string, even though the evasion suffix was only ever intended to be used as a suffix. With this commit, `~` and `@` are only treated specially if they occur as the last character on the line. In addition, it is now possible to escape a terminal `~` or `@` with a backslash. The only limitation is that the toolchain cannot handle a sequence such as `abc\\~`, which would result in `abc\\<suffix>` instead of `abc\<suffix>` because there's no special handling of backslash espaces in general. Fixes #185
theseion
force-pushed
the
restrict-use-of-evasion-modifiers-to-end-of-line
branch
from
d162120 to
a857774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now,
~and@would be replaced by the evasion suffix regardless of their position in the string, even though the evasion suffix was only ever intended to be used as a suffix. With this commit,~and@are only treated specially if they occur as the last character on the line.In addition, it is now possible to escape a terminal
~or@with a backslash. The only limitation is that the toolchain cannot handle a sequence such asabc\\~, which would result inabc\\<suffix>instead ofabc\<suffix>because there's no special handling of backslash espaces in general.Fixes #185