Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs/build: don't start new build until previous build completes #823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

jobs/build: don't start new build until previous build completes #823

wants to merge 2 commits into from

Commits on Feb 23, 2023

  1. jobs/build: gate all rerun logic on uploading 

    We only actually run the jobs when `uploading` is set. So it seems wrong
to update the build description. In fact, let's not even waste time
looking for missing arches or reading build metadata.

Patch best viewed with whitespace ignored.
    @jlebon
    jlebon committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    c2ad35d View commit details
    Browse the repository at this point in the history

  2. jobs/build: don't start new build until previous build completes 

    Since 973bcf9 ("jobs/build: rerun `build-arch` if previous build is
incomplete"), there is a race possible where the `build` job rerun logic
could kick in before the `release` jobs initially triggered for that
build has finished. We don't want to queue builds in that case.

Let's just prevent starting up the build job at all if there are
remaining pieces from another build for this stream running.

Co-authored-by: Jonathan Lebon <[email protected]>
    @dustymabe @jlebon
    dustymabe and jlebon committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    a084590 View commit details
    Browse the repository at this point in the history