Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: build legacy PXE images for now #258

Merged
merged 1 commit into from
Jul 27, 2020
Merged

pipeline: build legacy PXE images for now #258

merged 1 commit into from
Jul 27, 2020

Conversation

bgilbert
Copy link
Contributor

Generate a PXE rootfs image that only contains a flag file for alerting purposes. We'll switch to a real separate rootfs image after a deprecation period.

For coreos/fedora-coreos-tracker#390. Must be merged at the same time as coreos/coreos-assembler#1608.

Generate a PXE rootfs image that only contains a flag file for alerting
purposes.  We'll switch to a real separate rootfs image after a deprecation
period.
@dustymabe
Copy link
Member

dustymabe commented Jul 20, 2020

If we want to go ahead and do this for the next next (suggested in coreos/fedora-coreos-tracker#390 (comment)) then we'd just add some conditional logic in here to make that happen right?

@bgilbert bgilbert marked this pull request as ready for review July 27, 2020 12:15
@bgilbert
Copy link
Contributor Author

Right.

Ready for review.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert merged commit 0bbfb9c into coreos:master Jul 27, 2020
@bgilbert bgilbert deleted the rootfs branch July 27, 2020 15:26
@jlebon
Copy link
Member

jlebon commented Jul 27, 2020

Must be merged at the same time as coreos/coreos-assembler#1608.

Note for the future: we should merge pipeline changes which require cosa changes once a cosa image is available with that change. If we merge the two at the same time, it's unlikely going to be rebuilt in time and the pipeline could go red. (Or as what happened here; the Quay.io build died on a Fedora registry flake -- restarted it!)

@dustymabe
Copy link
Member

It's eventually consistent 🤣

@bgilbert
Copy link
Contributor Author

Note for the future: we should merge pipeline changes which require cosa changes once a cosa image is available with that change.

Noted. Though in this case, it's probably better to get a failed build than one with incorrect artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants