-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wi-Fi: auto-start connection #636
base: main
Are you sure you want to change the base?
Conversation
Adding the NetworkManager-wifi package as an extension does not automatically start the Wi-Fi connection. NetworkManager.service should be restarted to establish the connection.
@@ -58,6 +58,7 @@ systemd: | |||
RemainAfterExit=yes | |||
ExecStart=/usr/bin/rpm-ostree install --apply-live --allow-inactive NetworkManager-wifi iwlwifi-dvm-firmware | |||
ExecStart=/bin/touch /var/lib/%N.stamp | |||
ExecStartPost=/usr/bin/systemctl restart NetworkManager.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, feels like for a oneshot service, there isn't much difference between ExecStart=
and ExecStartPost=
? Fine as is too though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, did you try systemctl reload NetworkManager.service
instead? If that works, that should be preferred I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried systemctl reload NetworkManager.service
but it didn't work.
considering coreos/fedora-coreos-tracker#1691 (comment) which I had forgot about, I guess we should actually change the docs here to not use I think @jlebon is working on a doc update for this in the os extensions section and then we can update the docs on this page to do the same. at that point we won't need to restart NetworkManager because the system will have rebooted |
#637 (comment) should mean that we are rebooting at least for now.. @hrismarin we can leave this PR open for when coreos/fedora-coreos-tracker#1691 is fixed (@jlebon opened coreos/rpm-ostree#4939 for that) if you like. |
Adding the NetworkManager-wifi package as an extension does not automatically start the Wi-Fi connection. NetworkManager.service should be restarted to establish the connection.