tests/kola: add exceptions in upgrade test SELinux checks #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are failing in the extended upgrade tests and we need to add them as exceptions for now while we work out the fixes.
aaradhak
reviewed
Oct 4, 2024
| declare -A exceptions=( | ||
| ['/var/lib/cni']=1 | ||
| ['/etc/selinux/targeted/semanage.read.LOCK']=1 | ||
| ['/etc/selinux/targeted/semanage.trans.LOCK']=1 | ||
| ['/etc/systemd/journald.conf.d']=1 | ||
| ['/etc/systemd/journald.conf.d/forward-to-console.conf']=1 | ||
| ['/boot/lost+found']=1 | ||
| ['/var/lib/systemd/home']=1 |
There was a problem hiding this comment.
Just for my understanding - I assume that by adding this it ensures that the script doesn't falsely flag an error during SELinux policy updates?
There was a problem hiding this comment.
it just means that if that file shows up in the list of ones that would be relabeled (i.e. it doesn't match the current policy) then we allow it because of some known SELinux policy change that happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are failing in the extended upgrade tests and we need to add them as exceptions for now while we work out the fixes.