35coreos-ignition: randomize partition GUIDs on first boot #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will make the hack "touch /boot/ignition.firstboot" for coreos/fedora-coreos-tracker#399 more likely to break booting right? I think I'd say we should do something like hardcode "unconfigured" GUIDs in cosa, and then have this service be idempotent by only randomizing if it sees the unconfigured GUIDs? Or alternatively, is there a place in the GPT that we can store a bit of state? Anyways, code seems fine as is. |
We're already doing that; see line 35. |
We've been randomizing the disk GUID but not the partition GUIDs, contrary to the GPT spec. Partition GUIDs are already not stable identifiers, since new ones are generated by create_disk.sh on every image build, so ensure they're globally unique as well. Randomizing the ESP GUID will break any existing UEFI boot variable created by fallback.efi, so it's important that we only do this on the first boot (to not break existing systems) and only after our bootloader setup has been taught not to create boot variables (to not break new systems).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been randomizing the disk GUID but not the partition GUIDs, contrary to the GPT spec. Partition GUIDs are already not stable identifiers, since new ones are generated by
create_disk.shon every image build, so ensure they're globally unique as well.Randomizing the ESP GUID will break any existing UEFI boot variable created by
fallback.efi, so it's important that we only do this on the first boot (to not break existing systems) and only after our bootloader setup has been taught not to create boot variables (to not break new systems).Requires coreos/coreos-assembler#2421 or equivalent.