Add log-level param for buildextend subcommands #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrutkovs
force-pushed
the
ore-debug
branch
2 times, most recently
from
ddf24c4
to
819e3ce
Compare
jlebon
reviewed
Sep 24, 2019
When log-level is set for buildextend command it would be passed to `ore`. This would help with getting more info when upload fails
jlebon
approved these changes
Sep 24, 2019
| @@ -28,6 +28,7 @@ parser.add_argument("--build", help="Build ID", | |||
| parser.add_argument("--name-suffix", help="Suffix for name") | |||
| parser.add_argument("--regions", help="EC2 regions", | |||
| default=default_all_regions, nargs='+') | |||
| parser.add_argument("--log-level", help="ore log level") | |||
There was a problem hiding this comment.
ore log level
Related to this is #692. E.g. ideally we'd log way less to the terminal, and then --log-level here would allow bumping that up (in addition to passing it along to ore).
|
CI failing because of #778. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When log-level is set for buildextend command it would be passed to
ore.This would help with getting more info when upload fails.
Tested this in RHCOS pipeline