mantle/gcp: support c3 metal instance types

[dustymabe]

This requires the IDPF guest OS feature flag to be set when creating GCP images and also a TERMINATE maintenance policy and hyperdisk storage. With this change, after uploading a disk you can then test with kola with something like:

cosa kola run -p=gcp                        \
    --gcp-json-key=key.json                 \
    --gcp-project=project                   \
    --gcp-machinetype=c3-highcpu-192-metal  \
    --gcp-zone=us-central1-c basic

Related to coreos/fedora-coreos-tracker#1794

[dustymabe]

ignore golangci-lint - those failures are handled in #3876

[cgwalters]

Whenever we change the disk/cloud code we should also double check what the image builder code does since ideally in the future we unify with those, was that done?

[dustymabe]

Whenever we change the disk/cloud code we should also double check what the image builder code does since ideally in the future we unify with those, was that done?

No I didn't. It turns out I made a bad assumption.

The RHEL9 image somehow does have that guestOS feature enabled:

root@24de7c60b75c:~# gcloud compute images describe-from-family --project rhel-cloud rhel-9
architecture: X86_64
archiveSizeBytes: '8386093056'
creationTimestamp: '2024-09-10T13:40:19.697-07:00'
description: Red Hat, Red Hat Enterprise Linux, 9, x86_64 built on 20240910
diskSizeGb: '20'
enableConfidentialCompute: false
family: rhel-9
guestOsFeatures:
- type: UEFI_COMPATIBLE
- type: VIRTIO_SCSI_MULTIQUEUE
- type: SEV_CAPABLE
- type: SEV_SNP_CAPABLE
- type: SEV_LIVE_MIGRATABLE
- type: SEV_LIVE_MIGRATABLE_V2
- type: GVNIC
- type: IDPF
id: '4739446824535658588'
kind: compute#image
labelFingerprint: 42WmSpB8rSM=
licenseCodes:
- '7883559014960410759'
licenses:
- https://www.googleapis.com/compute/v1/projects/rhel-cloud/global/licenses/rhel-9-server
name: rhel-9-v20240910
rawDisk:
  containerType: TAR
  source: ''
selfLink: https://www.googleapis.com/compute/v1/projects/rhel-cloud/global/images/rhel-9-v20240910
sourceType: RAW
status: READY
storageLocations:
- asia
- eu
- us

and I assumed that since it did OSBuild already had that setting baked in. I guess there is some other source of truth for those images?

I'll open a PR over there too.

[major]

@dustymabe GCP builds these images with their own tooling. We could escalate it to them via internal channels if needed.

[dustymabe]

@dustymabe GCP builds these images with their own tooling. We could escalate it to them via internal channels if needed.

Thanks @major - no need. Just wanted to understand the delta and now we do.

[dustymabe]

@cgwalters - opened osbuild/images#929

[mike-nguyen]

/lgtm

[dustymabe]

ignore golangci-lint - those failures are handled in #3876

merging..