cosalib/ova: template VMware HW and OS versions from image.yaml; enable UEFI
#2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use this for anything, and other values are not likely to be drop-in replacements.
This was referenced Mar 17, 2022
cgwalters
reviewed
Mar 17, 2022
bgilbert
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Mar 17, 2022
Stick with hardware version 13 for now, but switch the OS ID from RHEL 7 to 64-bit Fedora. For coreos/coreos-assembler#2762.
FCOS and RHCOS want to set different VMware hardware versions and OS
type IDs. Read both from image.yaml, defaulting to the values we
currently use.
OVF images created by VMware Workstation 16.2.3 respectively record
Fedora and RHEL 8 guests as:
<OperatingSystemSection ovf:id="100" vmw:osType="fedora64Guest">
<OperatingSystemSection ovf:id="80" ovf:version="8" vmw:osType="rhel8_64Guest">
The ovf:id values are defined to come from CIM_OperatingSystem.OsType,
which defines 80 as "RedHat Enterprise Linux 64-Bit" and 100 as
"Linux 2.6.x 64-Bit". (2.6.x seems to be the last explicit kernel version
listed in the spec.) ovf:version appears to be the major version of the
OS. VMware's ovftool doesn't seem to care about either of those fields,
only the vmw:osType, so we hardcode the ovf:id to 100 and call it a day.
Disable Secure Boot due to coreos/ignition#1092. Co-authored-by: Joseph Callen <[email protected]>
|
Updated! |
jlebon
approved these changes
Mar 17, 2022
|
/retest |
1 similar comment
|
/retest |
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Stick with hardware version 13 for now, but switch the OS ID from RHEL 7 to 64-bit Fedora. For coreos/coreos-assembler#2762.
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Stick with hardware version 13 for now, but switch the OS ID from RHEL 7 to 64-bit Fedora. For coreos/coreos-assembler#2762.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCOS and RHCOS want to set different VMware hardware versions and OS type IDs. Read both from
image.yaml, defaulting to the values we currently use.OVF images created by VMware Workstation 16.2.3 respectively record Fedora and RHEL 8 guests as:
The
ovf:idvalues are defined to come fromCIM_OperatingSystem.OsType, which defines 80 asRedHat Enterprise Linux 64-Bitand 100 asLinux 2.6.x 64-Bit. (2.6.x seems to be the last explicit kernel version listed in the spec.)ovf:versionappears to be the major version of the OS. VMware'sovftooldoesn't seem to care about either of those fields, only thevmw:osType, so we hardcode theovf:idto 100 and call it a day.While we're at it, switch to UEFI, which we can do even with hardware version 13. Disable Secure Boot, though, due to coreos/ignition#1092.
For coreos/fedora-coreos-tracker#1119. Alternative to #2740. Fixes coreos/fedora-coreos-config#1494.