providers/vmware: allow avoiding iopl permission errors #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a fallback path for the backdoor-opening logic, in order to allow consuming applications to keep going when changing I/O access level is not allowed. Privileged mode is in theory more reliable but `kernel_lockdown(7)` may block it due to `iopl()` usage. Thus, we try that first and fall back if kernel blocks it.
arithx
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a fallback path for the backdoor-opening logic,
in order to allow Afterburn to keep going when changing
I/O access level is not allowed.
Privileged mode is in theory more reliable but
kernel_lockdown(7)may block it due to
iopl()usage. Thus, we try that first andfall back if kernel blocks it.
Ref: https://github.com/lucab/vmw_backdoor-rs/issues/6