w25q128_test #28
Closed
w25q128_test #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Wait 60 seconds. | ||
| delay(60000L); //時間を適切な時間に修正 | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
771-8bit
reviewed
Mar 17, 2024
| #include <Adafruit_SPIFlash.h> | ||
|
|
||
| #ifndef FLASH_CONFIG_H_ | ||
| #define FLASH_CONFIG_H_ |
There was a problem hiding this comment.
FLASH_CONFIG_H_はインクルードガードってやつなのでこれ関連の行は消してOK
https://www.jpcert.or.jp/sc-rules/c-pre06-c.html
| dataFile.print(","); | ||
| dataFile.print(reading, DEC); //必要なデータの代入 | ||
| dataFile.println(); | ||
| dataFile.close(); |
There was a problem hiding this comment.
open,print,closeにかかる時間をそれぞれmicros()使ってマイクロ秒単位で測って欲しい
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
背景
-あと記録したいデータを選択して記録を開始するタイミングを指定