Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressure #23

Closed
wants to merge 6 commits into from
Closed

Pressure #23

wants to merge 6 commits into from

Conversation

mikito5hoda
Copy link

以下確認して消してからプルリク出してください

概要

  • ひとことで

背景

  • なぜこのプルリクが必要なのか,みたいな話があれば.関連する資料があったらそれも貼る

変更範囲

  • ここまではこのプルリクで,こここから先は別のプルリクで,といった内容があれば書く
  • スコープが広すぎると判断したら途中で編集して良い


void setup() {
Serial.begin(115200);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

//if (!lps35hw.begin_SPI(LPS_CS)) {
//if (!lps35hw.begin_SPI(LPS_CS, LPS_SCK, LPS_MISO, LPS_MOSI)) {
Serial.println("Couldn't find LPS35HW chip");
while (1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Empty loop bodies should use {} or continue [whitespace/empty_loop_body] [5]

Serial.print("Temperature: ");
Serial.print(lps35hw.readTemperature());
Serial.println(" C");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

@771-8bit
Copy link
Member

こっちで対応したので閉じ

@771-8bit 771-8bit closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants