This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Improved HTTP transport handling of query parameters #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using coreapi to interact with an api that provides links in responses, that at times I would like to follow using the Client.get() method. These links include query parameters at times. A common example is listing paginated entries, wherein the page number for the "next" page may be a query parameter.
This pull request includes a minor change to the URL parser that allows it to combine query parameters that already exist in the url with those specified separately. This behavior is consistent with the python client.
I also included two tests: one with and one without query parameters specified outside the URL.