Skip to content

Commit

Permalink
CORE-8034 Renamed 'application/rpc-worker' module to 'application/res…
Browse files Browse the repository at this point in the history
…t-worker', updated helm charts accordingly (#3110)

* CORE-8034 Renamed 'application/rpc-worker' module to 'application/rest-worker', updated helm charts accordingly

* Modified Jenkins file to point at feature branch of corda-shared-build-pipeline-steps

* Updated shared-pipeline version in E2E compatability check, renamed processors/rpc dir to processors/rest

* Returning corda api version to 5.0.0.651-beta+ following green build

---------

Co-authored-by: Peter McKinney <[email protected]>
  • Loading branch information
ben-millar and pmck91 authored Feb 21, 2023
1 parent 29838aa commit 0937bed
Show file tree
Hide file tree
Showing 71 changed files with 281 additions and 281 deletions.
2 changes: 1 addition & 1 deletion .ci/e2eTests/Jenkinsfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('[email protected]') _
@Library('[email protected].1') _

endToEndPipeline(
assembleAndCompile: false,
Expand Down
6 changes: 3 additions & 3 deletions .ci/e2eTests/corda.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ workers:
secretKeyRef:
name: "kafka-credentials"
key: "p2pLinkManager"
rpc:
rest:
kafka:
sasl:
username:
value: "rpc"
value: "rest"
password:
valueFrom:
secretKeyRef:
name: "kafka-credentials"
key: "rpc"
key: "rest"
2 changes: 1 addition & 1 deletion .ci/e2eTests/prereqs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ kafka:
- "membership"
- "p2pGateway"
- "p2pLinkManager"
- "rpc"
- "rest"
2 changes: 1 addition & 1 deletion .ci/versionCompatibility/Jenkinsfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@Library('[email protected]') _
@Library('[email protected].1') _

cordaCompatibilityCheckPipeline()
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('[email protected]') _
@Library('[email protected].1') _

cordaPipeline(
dailyBuildCron: 'H H/6 * * *',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ private class CombinedWorkerParams {
@Option(names = ["-d", "--database-params"], description = ["Database parameters for the worker."])
var databaseParams = emptyMap<String, String>()

@Option(names = ["-r", "--rpc-params"], description = ["RPC parameters for the worker."])
var rpcParams = emptyMap<String, String>()
@Option(names = ["-r", "--rest-params"], description = ["REST parameters for the worker."])
var restParams = emptyMap<String, String>()

@Option(names = ["--hsm-id"], description = ["HSM ID which is handled by this worker instance."])
var hsmId = ""
Expand Down
2 changes: 1 addition & 1 deletion applications/workers/release/flow-worker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ helm upgrade --install corda -n corda `
--values values.yaml `
--wait
kubectl port-forward --namespace corda deployment/corda-rpc-worker 8888
kubectl port-forward --namespace corda deployment/corda-rest-worker 8888
```

### Uploading the CBP and creating the Virtual Node
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {
id 'corda.docker-app'
}

description 'RPC Worker'
description 'REST Worker'

sourceSets {
e2eTest {
Expand Down Expand Up @@ -106,13 +106,13 @@ tasks.named('e2eTest') {
}

["A", "B", "C"].each {cluster ->
if(System.getenv("E2E_CLUSTER_${cluster}_RPC_HOST") == null) {
environment "E2E_CLUSTER_${cluster}_RPC_HOST",
project.getProperties().getOrDefault("e2eCluster${cluster}RpcHost","localhost")
if(System.getenv("E2E_CLUSTER_${cluster}_REST_HOST") == null) {
environment "E2E_CLUSTER_${cluster}_REST_HOST",
project.getProperties().getOrDefault("e2eCluster${cluster}RestHost","localhost")
}
if(System.getenv("E2E_CLUSTER_${cluster}_RPC_PORT") == null) {
environment "E2E_CLUSTER_${cluster}_RPC_PORT",
project.getProperties().getOrDefault("e2eCluster${cluster}RpcPort","8888")
if(System.getenv("E2E_CLUSTER_${cluster}_REST_PORT") == null) {
environment "E2E_CLUSTER_${cluster}_REST_PORT",
project.getProperties().getOrDefault("e2eCluster${cluster}RestPort","8888")
}
if(System.getenv("E2E_CLUSTER_${cluster}_P2P_HOST") == null) {
environment "E2E_CLUSTER_${cluster}_P2P_HOST",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.libs.permissions.endpoints.v1.permission.PermissionEndpoint
import net.corda.libs.permissions.endpoints.v1.permission.types.PermissionResponseType
import net.corda.libs.permissions.endpoints.v1.permission.types.PermissionType
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.httprpc.client.exceptions.MissingRequestedResourceException
import net.corda.httprpc.response.ResponseEntity
import net.corda.libs.permissions.endpoints.v1.permission.PermissionEndpoint
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminUser
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminUser
import net.corda.httprpc.client.exceptions.MissingRequestedResourceException
import net.corda.httprpc.client.exceptions.RequestErrorException
import net.corda.httprpc.exception.ResourceAlreadyExistsException
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.httprpc.client.exceptions.MissingRequestedResourceException
import net.corda.libs.permissions.endpoints.v1.user.UserEndpoint
import net.corda.libs.permissions.endpoints.v1.user.types.CreateUserType
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.cli.CliTask
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.TestToolkitProperty.Companion.DEFAULT_HTTP_HOST
import net.corda.applications.workers.rpc.http.TestToolkitProperty.Companion.DEFAULT_HTTP_PORT
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminUser
import net.corda.applications.workers.rest.cli.CliTask
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.TestToolkitProperty.Companion.DEFAULT_HTTP_HOST
import net.corda.applications.workers.rest.http.TestToolkitProperty.Companion.DEFAULT_HTTP_PORT
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminUser
import net.corda.libs.permissions.endpoints.v1.role.RoleEndpoint
import net.corda.test.util.eventually
import net.corda.v5.base.util.seconds
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import java.time.Instant
import java.time.temporal.ChronoUnit.DAYS
import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminUser
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminUser
import net.corda.httprpc.client.exceptions.PermissionException
import net.corda.libs.permissions.endpoints.v1.permission.types.PermissionType
import org.assertj.core.api.Assertions
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.utils.E2eClusterAConfig
import net.corda.applications.workers.rpc.utils.E2eClusterBConfig
import net.corda.applications.workers.rpc.utils.E2eClusterCConfig
import net.corda.applications.workers.rpc.utils.E2eClusterFactory
import net.corda.applications.workers.rpc.utils.E2eClusterMember
import net.corda.applications.workers.rpc.utils.allowClientCertificates
import net.corda.applications.workers.rpc.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rpc.utils.setSslConfiguration
import net.corda.applications.workers.rpc.utils.generateGroupPolicy
import net.corda.applications.workers.rpc.utils.getGroupId
import net.corda.applications.workers.rpc.utils.onboardMembers
import net.corda.applications.workers.rpc.utils.onboardMgm
import net.corda.applications.workers.rest.utils.E2eClusterAConfig
import net.corda.applications.workers.rest.utils.E2eClusterBConfig
import net.corda.applications.workers.rest.utils.E2eClusterCConfig
import net.corda.applications.workers.rest.utils.E2eClusterFactory
import net.corda.applications.workers.rest.utils.E2eClusterMember
import net.corda.applications.workers.rest.utils.allowClientCertificates
import net.corda.applications.workers.rest.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rest.utils.setSslConfiguration
import net.corda.applications.workers.rest.utils.generateGroupPolicy
import net.corda.applications.workers.rest.utils.getGroupId
import net.corda.applications.workers.rest.utils.onboardMembers
import net.corda.applications.workers.rest.utils.onboardMgm
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Disabled
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import java.time.Instant
import java.time.temporal.ChronoUnit.DAYS
import java.util.concurrent.Executors
import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminUser
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminUser
import net.corda.libs.permissions.endpoints.v1.permission.PermissionEndpoint
import net.corda.libs.permissions.endpoints.v1.permission.types.PermissionType
import net.corda.test.util.eventually
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import java.time.Instant
import java.time.temporal.ChronoUnit.DAYS
import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminUser
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminUser
import net.corda.libs.permissions.endpoints.v1.permission.types.PermissionType
import net.corda.test.util.eventually
import org.assertj.core.api.Assertions.assertThat
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import java.time.Instant
import net.corda.applications.workers.rpc.http.TestToolkit
import net.corda.applications.workers.rest.http.TestToolkit
import net.corda.libs.permissions.endpoints.v1.permission.PermissionEndpoint
import net.corda.libs.permissions.endpoints.v1.permission.types.BulkCreatePermissionsRequestType
import net.corda.libs.permissions.endpoints.v1.permission.types.CreatePermissionType
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.utils.E2eClusterAConfig
import net.corda.applications.workers.rpc.utils.E2eClusterBConfig
import net.corda.applications.workers.rpc.utils.E2eClusterCConfig
import net.corda.applications.workers.rpc.utils.E2eClusterFactory
import net.corda.applications.workers.rpc.utils.E2eClusterMember
import net.corda.applications.workers.rpc.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rpc.utils.setSslConfiguration
import net.corda.applications.workers.rpc.utils.disableLinkManagerCLRChecks
import net.corda.applications.workers.rpc.utils.generateGroupPolicy
import net.corda.applications.workers.rpc.utils.getGroupId
import net.corda.applications.workers.rpc.utils.onboardMembers
import net.corda.applications.workers.rpc.utils.onboardMgm
import net.corda.applications.workers.rest.utils.E2eClusterAConfig
import net.corda.applications.workers.rest.utils.E2eClusterBConfig
import net.corda.applications.workers.rest.utils.E2eClusterCConfig
import net.corda.applications.workers.rest.utils.E2eClusterFactory
import net.corda.applications.workers.rest.utils.E2eClusterMember
import net.corda.applications.workers.rest.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rest.utils.setSslConfiguration
import net.corda.applications.workers.rest.utils.disableLinkManagerCLRChecks
import net.corda.applications.workers.rest.utils.generateGroupPolicy
import net.corda.applications.workers.rest.utils.getGroupId
import net.corda.applications.workers.rest.utils.onboardMembers
import net.corda.applications.workers.rest.utils.onboardMgm
import org.assertj.core.api.Assertions
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.utils.E2eClusterFactory
import net.corda.applications.workers.rpc.utils.E2eClusterMember
import net.corda.applications.workers.rpc.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rpc.utils.assertP2pConnectivity
import net.corda.applications.workers.rpc.utils.generateGroupPolicy
import net.corda.applications.workers.rpc.utils.getGroupId
import net.corda.applications.workers.rpc.utils.onboardMembers
import net.corda.applications.workers.rpc.utils.onboardMgm
import net.corda.applications.workers.rest.utils.E2eClusterFactory
import net.corda.applications.workers.rest.utils.E2eClusterMember
import net.corda.applications.workers.rest.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rest.utils.assertP2pConnectivity
import net.corda.applications.workers.rest.utils.generateGroupPolicy
import net.corda.applications.workers.rest.utils.getGroupId
import net.corda.applications.workers.rest.utils.onboardMembers
import net.corda.applications.workers.rest.utils.onboardMgm
import net.corda.data.identity.HoldingIdentity
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import net.corda.applications.workers.rpc.utils.E2eClusterFactory
import net.corda.applications.workers.rpc.utils.E2eClusterMember
import net.corda.applications.workers.rpc.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rpc.utils.assertP2pConnectivity
import net.corda.applications.workers.rpc.utils.createStaticMemberGroupPolicyJson
import net.corda.applications.workers.rpc.utils.getCa
import net.corda.applications.workers.rpc.utils.onboardStaticMembers
import net.corda.applications.workers.rest.utils.E2eClusterFactory
import net.corda.applications.workers.rest.utils.E2eClusterMember
import net.corda.applications.workers.rest.utils.assertAllMembersAreInMemberList
import net.corda.applications.workers.rest.utils.assertP2pConnectivity
import net.corda.applications.workers.rest.utils.createStaticMemberGroupPolicyJson
import net.corda.applications.workers.rest.utils.getCa
import net.corda.applications.workers.rest.utils.onboardStaticMembers
import net.corda.data.identity.HoldingIdentity
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package net.corda.applications.workers.rpc
package net.corda.applications.workers.rest

import java.time.Instant
import java.time.temporal.ChronoUnit.DAYS
import net.corda.applications.workers.rpc.http.TestToolkitProperty
import net.corda.applications.workers.rpc.http.SkipWhenRestEndpointUnavailable
import net.corda.applications.workers.rest.http.TestToolkitProperty
import net.corda.applications.workers.rest.http.SkipWhenRestEndpointUnavailable
import net.corda.httprpc.client.exceptions.MissingRequestedResourceException
import net.corda.httprpc.client.exceptions.RequestErrorException
import net.corda.httprpc.exception.ResourceAlreadyExistsException
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package net.corda.applications.workers.rpc.cli
package net.corda.applications.workers.rest.cli

import org.slf4j.LoggerFactory
import java.io.BufferedReader
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package net.corda.applications.workers.rpc.cli
package net.corda.applications.workers.rest.cli

data class CliTaskResult(val exitCode: Int, val stdOut: String, val stdErr: String)
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package net.corda.applications.workers.rpc.http
package net.corda.applications.workers.rest.http

import net.corda.libs.permissions.endpoints.v1.user.UserEndpoint
import org.junit.jupiter.api.extension.ConditionEvaluationResult
Expand Down Expand Up @@ -54,7 +54,7 @@ internal class EndpointAvailabilityCondition : ExecutionCondition {
}

/**
* Checks to see if HTTP RPC endpoint is reachable
* Checks to see if REST endpoint is reachable
*
* @return true if reachable, false if not
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package net.corda.applications.workers.rpc.http
package net.corda.applications.workers.rest.http

import org.junit.jupiter.api.extension.ExtendWith

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package net.corda.applications.workers.rpc.http
package net.corda.applications.workers.rest.http

import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rpc.utils.AdminPasswordUtil.adminUser
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminPassword
import net.corda.applications.workers.rest.utils.AdminPasswordUtil.adminUser
import net.corda.httprpc.RestResource
import net.corda.httprpc.client.RestClient

Expand All @@ -19,7 +19,7 @@ interface TestToolkit {
* Creates the [RestClient] for a given [RestResource] class.
*/
fun <I : RestResource> httpClientFor(
rpcOpsClass: Class<I>,
restResourceClass: Class<I>,
userName: String = adminUser,
password: String = adminPassword
): RestClient<I>
Expand Down
Loading

0 comments on commit 0937bed

Please sign in to comment.