-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-6717 Add schemas for hosted identity reconciliation #1620
Conversation
Jenkins build for PR 1620 build 9 Build Successful: |
Scanning for breaking API changes introduced by this PR Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1620/8/ If the breaking changes are intentional, run |
data/avro-schema/src/main/resources/avro/net/corda/data/p2p/HostedIdentityEntry.avsc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot go in 5.2 as patch releases must be able to be applied in place (without an upgrade process for DBs etc).
@driessamyn The main problem is that we were not persisting data in the DB, so in case of kafka data loss we lost everything. |
@@ -61,6 +61,13 @@ | |||
"minimum": 5000, | |||
"maximum": 2147483647, | |||
"default": 120000 | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up, after upgrade it's possible the config read by a worker will not yet have this property with a default propagated to it. The code must be able to handle this property is missing in 5.2.1. See https://r3-cev.atlassian.net/wiki/spaces/CB/pages/4564091182/Making+a+Config+Change for more details.
Removing block as confirmed with Marcello (pending write-up of decision) that this can go in 5.2.1.
Quality Gate passedIssues Measures |
Non-blocking downstream job failed for corda-non-functional-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1620/8/ has failed for PR 1620 build 8 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test |
Non-blocking downstream job failed for corda-e2e-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1620/8/ has failed for PR 1620 build 8 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduces database and Avro schemas to enable persistence and reconciliation of locally-hosted identities.
hosted_identity
andhosted_identity_session_key_info
HostedIdentityEntry.avsc
to includeversion
(compatibility test added)