Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrades to CRS 4.1. #1032

Merged
merged 5 commits into from
May 10, 2024
Merged

chore: upgrades to CRS 4.1. #1032

merged 5 commits into from
May 10, 2024

Conversation

jcchavezs
Copy link
Member

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@jcchavezs jcchavezs requested a review from a team as a code owner April 2, 2024 16:33
jcchavezs
jcchavezs commented Apr 11, 2024
View reviewed changes
testing/coreruleset/.ftw.yml
@@ -7,5 +7,8 @@ testoverride:
920270-4: 'Rule works, log contains 920270. Test expects status 400 (Apache behaviour)'
920272-5: 'Rule works, log contains 920272. Test expects status 400 (Apache behaviour)'
920290-1: 'Rule works, log contains 920290. Test expects status 400 (Apache behaviour)'
920290-4: 'Go/http returns 400 Bad Request: missing required Host header'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably provide a list of rules to remove in the http package for those that are already blocked by standard http handler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where? How?

@M4tteoP
Copy link
Member

M4tteoP commented May 8, 2024

#1061 is meant to fix 942440-19 and 942440-20, with that PR merged we should finally be able to merge this one and most likely update also to CRS 4.2 later on.

@jcchavezs jcchavezs added the v3.2 label May 9, 2024
@jcchavezs jcchavezs merged commit 1c3776a into main May 10, 2024
7 checks passed
@jcchavezs jcchavezs deleted the uses_crs_41 branch May 10, 2024 22:43
@M4tteoP M4tteoP mentioned this pull request May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi left review comments

@M4tteoP M4tteoP M4tteoP approved these changes

Assignees
No one assigned
Labels
v3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcchavezs @M4tteoP @fzipi