tests: adds mage target for CRS benchmarks. #1003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Feb 13, 2024
| @@ -53,7 +53,7 @@ func BenchmarkCRSCompilation(b *testing.B) { | |||
| } | |||
| } | |||
|
|
|||
| func BenchmarkCRSSimpleGET(b *testing.B) { | |||
| func BenchmarkCRSRuntimeSimpleGET(b *testing.B) { | |||
There was a problem hiding this comment.
I'm not too clear on what Runtime means here. If it means running time of the operation, I think all benchmarks measure that so doesn't need to be in name
jptosso
reviewed
Apr 5, 2024
|
|
||
| func CRSBenchmark() error { | ||
| bench := "BenchmarkCRSRuntime(Simple|Large)(GET|POST)" | ||
| err := sh.RunV("go", "test", "-run=^$,", "-benchmem", "-bench=^"+bench+"$", "./testing/coreruleset", "-cpuprofile=cpuprof.out") |
There was a problem hiding this comment.
This may be ambiguous; what about running the benchmark for results and adding a parameter to create a CPU profile?
|
@jcchavezs Care to take a look at comments, or just merge? |
|
@jcchavezs Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ease benchmark running