Skip to content

Emit right-sized batches from GroupedHashAggregateStream #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joroKr21
Copy link

@joroKr21 joroKr21 commented May 16, 2025

Which issue does this PR close?

https://coralogix.atlassian.net/browse/VTX-9179

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@joroKr21 joroKr21 force-pushed the aggregate-exec branch 2 times, most recently from 4c07862 to 1aed113 Compare May 16, 2025 09:34
@joroKr21 joroKr21 force-pushed the aggregate-exec branch 6 times, most recently from 5e570d2 to 0376571 Compare May 16, 2025 12:25
@joroKr21 joroKr21 requested review from a team May 16, 2025 16:23
@joroKr21
Copy link
Author

The problem with this approach is that the data is copied for each EmitTo::First(n) call because it uses Vec::split_off under the hood. Instead, we can use partitioned aggregations with two target partitions until the upstream is improved.

@joroKr21 joroKr21 closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants