VTX-4075: make one method public and clippy happy

datafusion-cli/src/functions.rs

@@ -297,7 +297,7 @@ pub struct ParquetMetadataFunc {}
 
 impl TableFunctionImpl for ParquetMetadataFunc {
     fn call(&self, exprs: &[Expr]) -> Result<Arc<dyn TableProvider>> {
-        let filename = match exprs.get(0) {
+        let filename = match exprs.first() {
             Some(Expr::Literal(ScalarValue::Utf8(Some(s)))) => s, // single quote: parquet_metadata('x.parquet')
             Some(Expr::Column(Column { name, .. })) => name, // double quote: parquet_metadata("x.parquet")
             _ => {

datafusion/common/src/error.rs

@@ -530,6 +530,7 @@ macro_rules! sql_err {
 
 // To avoid compiler error when using macro in the same crate:
 // macros from the current crate cannot be referred to by absolute paths
+#[allow(unused_imports)]
 pub use exec_err as _exec_err;
 pub use internal_err as _internal_err;
 pub use not_impl_err as _not_impl_err;
@@ -581,7 +582,6 @@ mod test {
 
     #[cfg(not(feature = "backtrace"))]
     #[test]
-    #[allow(clippy::unnecessary_literal_unwrap)]
     fn test_disabled_backtrace() {
         let res: Result<(), DataFusionError> = plan_err!("Err");
         let res = res.unwrap_err().to_string();
@@ -645,7 +645,6 @@ mod test {
     }
 
     #[test]
-    #[allow(clippy::unnecessary_literal_unwrap)]
     fn test_make_error_parse_input() {
         let res: Result<(), DataFusionError> = plan_err!("Err");
         let res = res.unwrap_err();

datafusion/core/src/physical_optimizer/projection_pushdown.rs

@@ -985,6 +985,7 @@ fn join_table_borders(
 
 /// Tries to update the equi-join `Column`'s of a join as if the the input of
 /// the join was replaced by a projection.
+#[allow(clippy::map_identity)]
 fn update_join_on(
     proj_left_exprs: &[(Column, String)],
     proj_right_exprs: &[(Column, String)],

datafusion/optimizer/src/simplify_expressions/guarantees.rs

@@ -43,6 +43,7 @@ pub(crate) struct GuaranteeRewriter<'a> {
 }
 
 impl<'a> GuaranteeRewriter<'a> {
+    #[allow(clippy::map_identity)]
     pub fn new(
         guarantees: impl IntoIterator<Item = &'a (Expr, NullableInterval)>,
     ) -> Self {

datafusion/physical-expr/src/array_expressions.rs

@@ -2147,7 +2147,7 @@ pub fn general_array_distinct<OffsetSize: OffsetSizeTrait>(
         let last_offset: OffsetSize = offsets.last().copied().unwrap();
         offsets.push(last_offset + OffsetSize::usize_as(rows.len()));
         let arrays = converter.convert_rows(rows)?;
-        let array = match arrays.get(0) {
+        let array = match arrays.first() {
             Some(array) => array.clone(),
             None => {
                 return internal_err!("array_distinct: failed to get array from rows")

datafusion/physical-plan/src/common.rs

@@ -97,7 +97,7 @@ fn build_file_list_recurse(
 
 /// If running in a tokio context spawns the execution of `stream` to a separate task
 /// allowing it to execute in parallel with an intermediate buffer of size `buffer`
-pub(crate) fn spawn_buffered(
+pub fn spawn_buffered(
     mut input: SendableRecordBatchStream,
     buffer: usize,
 ) -> SendableRecordBatchStream {

datafusion/sqllogictest/src/engines/datafusion_engine/mod.rs

@@ -21,5 +21,5 @@ mod normalize;
 mod runner;
 
 pub use error::*;
-pub use normalize::*;
+
 pub use runner::*;