Add the opam files for the 9.0 branch. #3289
Conversation
| ] | ||
|
|
||
| url { | ||
| src: "git+https://github.com/coq/coq.git#master" |
There was a problem hiding this comment.
No, this should have been src: "git+https://github.com/coq/coq.git#v9.0", and similarly for the other packages. Otherwise people will be testing master instead of the branch.
If the checklist for the release said to use "master" here, it is blatantly incorrect.
| conflicts: [ | ||
| "coq" { < "8.17" } | ||
| ] | ||
| depopts: ["coq-native"] |
There was a problem hiding this comment.
It seems like the opam files from the 9.0 branch were not used as a basis for this pull request.
This should read
depopts: ["rocq-native" "memprof-limits" "memtrace"]
(For some reason, Github does not allow me to do suggestions. Maybe they are no longer allowed once a pull request has been merged.)
| "-prefix" prefix | ||
| "-mandir" man | ||
| "-libdir" "%{lib}%/coq" | ||
| "-native-compiler" "yes" {coq-native:installed} "no" {!coq-native:installed} |
There was a problem hiding this comment.
"-native-compiler" "yes" {rocq-native:installed} "no" {!rocq-native:installed}
| bug-reports: "https://github.com/coq/coq/issues" | ||
| depends: [ | ||
| "dune" {>= "3.8"} | ||
| "coq-core" {= version} |
There was a problem hiding this comment.
It should be the following instead.
"rocq-runtime" {= version}
| "coq-core" {= version} | ||
| "odoc" {with-doc} | ||
| ] | ||
| depopts: ["coq-native"] |
There was a problem hiding this comment.
The depopts are already in rocq-runtime.
I have no idea what I'm doing but I'm following the release process doc. This is treacherous after the renaming. I did tweak some of the new opam files to reflect the name change but please double-check this thorougly.