Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multinomials 2.3.0 #3250

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

CohenCyril
Copy link
Contributor

No description provided.

@CohenCyril CohenCyril marked this pull request as draft December 12, 2024 13:18
@palmskog
Copy link
Collaborator

@CohenCyril I don't understand why this was marked as a draft. The only failure in CI was an opam timeout on the "any" job which is unrelated to the package, all other jobs passed.

@CohenCyril
Copy link
Contributor Author

Ok! I was just lacking the time to investigate

@CohenCyril CohenCyril marked this pull request as ready for review December 14, 2024 17:31
@palmskog palmskog merged commit d567199 into coq:master Dec 14, 2024
2 of 4 checks passed
@palmskog
Copy link
Collaborator

palmskog commented Dec 14, 2024

Wait, even though CI passed, I don't understand how this build can install anything meaningful when there is no dune-project or dune file in the archive (and Dune is not the build system used in the project's CI). I'll investigate.

@CohenCyril
Copy link
Contributor Author

Ah damnit... The build system was reverted to gnu make 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants