-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opam package for new version coq-unimath.20240923 #3227
Conversation
@MSoegtropIMC : thanks a lot for preparing this. I think that 8.18 is a good lower bound for now: we know that 8.17 does not work, and I am not sure about 8.18. 8.19 works. |
All CI tests timed out. Unimath is the longest running package in Coq Platform so this is expected. IMHO this is good to merge. |
Could someone please try this locally on 8.18? |
I just started a compilation of the zip archive obtained at https://github.com/UniMath/UniMath/archive/refs/tags/v20240923.zip Remind if I forget to report on the result in due time. |
Compilation failed on my machine, here is the error message.
|
@ybertot : thanks a lot for checking compilation with 8.18! |
Don't mention it, I believe the energy used to make this verification contributed to making my office warmer! |
Yes, unimath is one of the longer running builds - indeed it is usually the last one running in a Coq Platform build. Thanks for going through this! |
Could you please bump the Coq bound? It would also be very useful if we confirmed that package works on 8.19. |
I am currently too busy with other Coq Platform things to check it on 8.19. |
I confirm that it works on 8.19. |
OK, then I change the lower bound to 8.19. |
This should be good to merge now. @palmskog : I am a bist astonished that CI didn't time out (it took 54min). What are the current time limits for CI? |
@MSoegtropIMC Gaëtan changed recently to better runners for opam CI. |
I didn't test the Coq lower bound - this is taken from the previous package.
I tested that this works with Coq 8.20.0.
@benediktahrens : if you have evidence on the Coq lower bound, please let me know. Otherwise I would suggest to keep it like this until someone fonds out that it does not work.
I guess CI will time out (not sure).