Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package for coq's bench for neural-net interp project #2709

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

JasonGross
Copy link
Member

No description provided.

The package is only for benching coq, anyway
@JasonGross
Copy link
Member Author

CI passes, does someone need to review to merge this?

@palmskog
Copy link
Contributor

palmskog commented Sep 8, 2023

I don't understand why coq-native is an absolute dependency here, but since this is extra-dev, fine by me to merge.

@palmskog palmskog merged commit 8e333bd into coq:master Sep 8, 2023
3 checks passed
@JasonGross JasonGross deleted the add-neural-net-coq-interp branch September 8, 2023 23:02
@JasonGross
Copy link
Member Author

I don't understand why coq-native is an absolute dependency here, but since this is extra-dev, fine by me to merge.

I guess maybe it shouldn't be an absolute dependency. It was intended to make sure that you don't install this thinking that you're benching the native compiler when in fact you're just benching the vm, but maybe I should disable the requirement?

@JasonGross
Copy link
Member Author

I'll see what the other coqdevs think at coq/coq#18028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants