-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port to rocq 9 #153
port to rocq 9 #153
Conversation
reactivate Nix CI for 8.20
@damien-pous can we please not merge this into |
@damien-pous I changed the PR to target |
Will try... |
If it's too much work, you could also make a new branch in your own repo based on the current |
I'll probably do that: I've tried something but it does not longer compile (can't see why), and we would get very weird commit history if we continue with this PR. |
I think the problem is you still the need the following diff to compile: diff --git a/_CoqProject b/_CoqProject
index cf13fea..cb7f43e 100644
--- a/_CoqProject
+++ b/_CoqProject
@@ -4,7 +4,6 @@
-I src
-arg -w -arg +default
--arg -w -arg -deprecated-from-Coq
src/coq.mli
src/helper.mli But feel free to push this tomorrow and I can take over from there. |
As to the commit history, I can do a squash merge so the unneeded changes disappear. |
Hi @palmskog, The problem was just that I was trying to compile with make... instead of dune. There is still a dune warning about Coq language version, which I have not clue how to fix. |
There is no need to fix the Dune warning, I'll take it from here and merge. |
great, thanks! |
tentative version for rocq 9
we had either to use -deprecated-from-Coq, or to rename the corresponding imports.
since we had to do a new version anyways, I did the latter.
I've also added the changes that were pending in coq-community branches, I hope this is ok