Fix #352 again #357
Merged
Fix #352 again #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakotomandimby
approved these changes
Apr 2, 2025
bbatsov
pushed a commit
to bbatsov/copilot.el
that referenced
this pull request
Apr 5, 2025
|
Seems this resulted in an another issue - #405. |
|
I think this should be reverted for now, it results in other issues (#405, #409) that I think are a lot more annoying that the original issue it is trying to fix. In particular #409 makes it impossible to just write code normally with |
|
Yeah, I'll revert it. Would have done it earlier, if I could just commit this directly, but now it's a bit of a hassle. |
bbatsov
added a commit
to bbatsov/copilot.el
that referenced
this pull request
Apr 17, 2025
This reverts commit 5fa27b5.
Thanks! |
|
I've also cut a new release 0.2, for the people who are using MELPA Stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll need some help with this. This fixes the issue observed in #352 (comment), but I'm not sure this is the correct way and if it will create other problems.
The first observation is that the code deletion problem is not coming from the the code I added that removes extra indentation. So I don't fully understand why my changes created the issue.
I also observed that
startandendwould always be the same value, unless some text gets inserted before the completion (repro of the issue). So settingstarttoend"fixes" it.The problem is that I don't fully understand what the purpose of those 2 values is. Is it for a refactor/rewrite feature?