Address MELPA comments (update summary and use derived-mode-p) #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Dec 13, 2024
DamienCassou
approved these changes
Dec 14, 2024
|
Thank you! |
2 tasks
wangyuehong
pushed a commit
to wangyuehong/copilot.el
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I saw there were a few outstanding issues on melpa/melpa#9217 / #120 and they seemed easy enough to address except for:
You should depend on (emacs "29.1") if you need `python-ts-mode'.which as suggested by the melpa maintainer, seems like a false positive to me.Hope this is helpful, thanks!