Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] add new module website_rebrand_coopiteasy #313

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

huguesdk
Copy link
Member

@huguesdk huguesdk commented Mar 8, 2024

description

add a new module to replace the default odoo website branding by a coop it easy branding.

odoo task

t12258

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (cb0d67d) to head (df12d7a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             12.0     #313   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files         153      153           
  Lines        2012     2012           
  Branches      366      366           
=======================================
  Hits         1408     1408           
- Misses        565      566    +1     
+ Partials       39       38    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huguesdk huguesdk force-pushed the 12.0-add-website_rebrand_coopiteasy branch 4 times, most recently from 1d27794 to 318a367 Compare March 9, 2024 11:31
Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a comment than a review : "Odoo by Coop IT Easy" sounds like Odoo is a product from Coop IT Easy. I would be more precise, for instance "Odoo, supplied by Coop IT Easy".

@huguesdk
Copy link
Member Author

indeed. i had the same impression, and your suggestion sounds very good and accurate. other options i think of would be “provided by” or “managed by”.

Copy link
Member

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huguesdk huguesdk force-pushed the 12.0-add-website_rebrand_coopiteasy branch 2 times, most recently from a0ce9ae to c7a17fc Compare March 18, 2024 10:01
@huguesdk
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-313-by-huguesdk-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 90be141 into 12.0 Mar 22, 2024
2 checks passed
@github-grap-bot github-grap-bot deleted the 12.0-add-website_rebrand_coopiteasy branch March 22, 2024 09:12
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at dd07f0f. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants