[REF] resource_work_time_from_contracts: remove readonly #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line has the side effect of issuing a warning for all models inheriting resource.mixin and setting defaults to resource_calendar_id. The readonly was introduced to prevent modifications by the user since the modules computes it. It is however to relevant since the field is hidden (readonly parameter only affects the views).
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #312 +/- ##
==========================================
- Coverage 97.71% 97.71% -0.01%
==========================================
Files 26 26
Lines 482 481 -1
Branches 52 52
==========================================
- Hits 471 470 -1
Misses 4 4
Partials 7 7 ☔ View full report in Codecov by Sentry. |
huguesdk
requested changes
Feb 2, 2024
robinkeunen
force-pushed
the
16.0-r_work_time_from_contracts-readonly
branch
from
0cf1492
to
7047976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line has the side effect of issuing a warning for all models inheriting resource.mixin and setting defaults to resource_calendar_id.
The readonly was introduced to prevent modifications by the user since the modules computes it. It is however to relevant since the field is hidden (readonly parameter only affects the views).
fixes #311