Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] portal_customer_wallet #299

Merged
merged 13 commits into from
Feb 23, 2024
Merged

[16.0][MIG] portal_customer_wallet #299

merged 13 commits into from
Feb 23, 2024

Conversation

carmenbianca
Copy link
Member

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=10800&action=479&model=project.task&view_type=form&menu_id=536

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

carmenbianca and others added 4 commits July 4, 2023 10:48
@carmenbianca
[ADD] portal_customer_wallet
82259f6 
Split from prior work on spp_portal_customer_wallet

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
[UPD] Update portal_customer_wallet.pot
68880c7 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@github-grap-bot @carmenbianca
[UPD] README.rst
d1bb7f2 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
[IMP] portal_customer_wallet: black, isort, prettier
9f5050c
@carmenbianca carmenbianca force-pushed the 16.0-mig-portal_customer_wallet branch from 01cd7da to cb6389a Compare July 4, 2023 15:27
huguesdk
huguesdk requested changes Jul 5, 2023
View reviewed changes
portal_customer_wallet/controllers/main.py Outdated Show resolved Hide resolved
portal_customer_wallet/__manifest__.py Outdated Show resolved Hide resolved
portal_customer_wallet/models/res_partner.py Outdated Show resolved Hide resolved
portal_customer_wallet/tests/common.py Outdated Show resolved Hide resolved
portal_customer_wallet/tests/common.py Outdated Show resolved Hide resolved
@carmenbianca carmenbianca force-pushed the 16.0-mig-portal_customer_wallet branch from cb6389a to 591a0c8 Compare July 5, 2023 09:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.06422% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 94.17%. Comparing base (e110213) to head (22e18e5).
Report is 45 commits behind head on 16.0.

Files Patch % Lines
portal_customer_wallet/controllers/main.py 25.00% 24 Missing ⚠️
portal_customer_wallet/tests/common.py 96.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             16.0     #299      +/-   ##
==========================================
- Coverage   97.73%   94.17%   -3.56%     
==========================================
  Files          12       34      +22     
  Lines         221      584     +363     
  Branches       30       56      +26     
==========================================
+ Hits          216      550     +334     
- Misses          1       27      +26     
- Partials        4        7       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carmenbianca carmenbianca force-pushed the 16.0-mig-portal_customer_wallet branch from f50284b to 3fcd6c5 Compare July 5, 2023 13:18
huguesdk
huguesdk approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes. 👍

polchampion
polchampion approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succesfully tested functionnaly

@carmenbianca
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-299-by-carmenbianca-bump-nobump, awaiting test results.

github-grap-bot added a commit that referenced this pull request Feb 23, 2024
@github-grap-bot
Merge PR #299 into 16.0
602b24d 
Signed-off-by carmenbianca
@github-grap-bot
Copy link
Contributor

@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-299-by-carmenbianca-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@carmenbianca
[FIX] account_customer_wallet: Undo a check that is incorrect
22e18e5 
This caused the test to fail

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-299-by-carmenbianca-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 9552d0a into 16.0 Feb 23, 2024
2 checks passed
@github-grap-bot github-grap-bot deleted the 16.0-mig-portal_customer_wallet branch February 23, 2024 19:24
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 110387a. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polchampion polchampion polchampion approved these changes

@huguesdk huguesdk huguesdk approved these changes

@robinkeunen robinkeunen Awaiting requested review from robinkeunen

@remytms remytms Awaiting requested review from remytms

@victor-champonnois victor-champonnois Awaiting requested review from victor-champonnois

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carmenbianca @codecov-commenter @github-grap-bot @huguesdk @polchampion