Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rabbit-mq #3330

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

djsisson
Copy link
Contributor

@djsisson djsisson commented Sep 5, 2024

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Sep 10, 2024
Copy link

gitguardian bot commented Sep 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@peaklabs-dev
Copy link
Member

@djsisson why is it not enough if we add a persitant volume:

services:
  rabbitmq:
    image: rabbitmq:3-management
    environment:
      - SERVICE_FQDN_RABBITMQ_15672
      - RABBITMQ_DEFAULT_USER=$SERVICE_USER_RABBITMQ
      - RABBITMQ_DEFAULT_PASS=$SERVICE_PASSWORD_RABBITMQ
      - PORT=${PORT:-5672}
    ports:
      - ${PORT}:5672
    healthcheck:
      test: rabbitmq-diagnostics -q ping
      interval: 5s
      timeout: 30s
      retries: 10
    volumes:
      - rabbitmq-data:/var/lib/rabbitmq/

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 7, 2024
@djsisson
Copy link
Contributor Author

djsisson commented Oct 7, 2024

see linked gh issue on rabbitmq

'if hostname is not provided, it creates a random hostname each time service is restarted.'
which means although the volume stays the same, all previous data in there is not used due to using a new hostname

ah i see, maybe youre right, i didnt see it wasnt global storage :)

@peaklabs-dev
Copy link
Member

But this is just rabbitmq issue this does not happen with docker in general, right or am I wrong?

@djsisson
Copy link
Contributor Author

djsisson commented Oct 7, 2024

this is just a rabbitmq issue

if you run without host and check logs/volumes you get something like this

/var/lib/rabbitmq/mnesia/rabbit@ee90f8d1363e

restart

/var/lib/rabbitmq/mnesia/rabbit@32b510b78640

setting a hostname stops this from happening

@peaklabs-dev peaklabs-dev changed the base branch from next to new-services October 7, 2024 12:35
@peaklabs-dev
Copy link
Member

Alright looks good.
Thank you for the PR 💜.

@peaklabs-dev peaklabs-dev merged commit db8c59e into coollabsio:new-services Oct 7, 2024
1 check passed
@github-actions github-actions bot removed 💤 Waiting for feedback Issues awaiting a response from the author. ⚙️ Service Issues requesting or PRs adding/fixing service templates. labels Oct 7, 2024
@djsisson djsisson deleted the fix-rabbitmq branch October 9, 2024 15:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants