Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Install Scripts #2733

Closed

Conversation

LEstradioto
Copy link
Contributor

THIS IS SUPPOSED TO BE A MERGE AFTER #2710

I was working on #2710 and thought that a more readable and testable install.sh would be nice. This is a starting point that would facilitate further changes.

Cursor_gY4kbw2tTI

Changes made:

  • Encapsulation
  • Added colors, logo, env vars flags
  • Shellcheck ok

- Encapsulation
- Added colors, logo, env vars flags
- Shellcheck ok
Copy link

gitguardian bot commented Sep 19, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - GitHub App Keys ccbbfd8 database/seeders/GithubAppSeeder.php View secret
- - Generic Password e1bcae7 templates/compose/resend.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@andrasbacsai
Copy link
Member

A lot of things changed since then, so this needs to be reviewed @LEstradioto (sorry about that).

@peaklabs-dev
Copy link
Member

@LEstradioto Is this still needed with the current install script? I know the other one to change the source dir is still open and needed.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 12, 2024
@LEstradioto
Copy link
Contributor Author

Yes, I think it still needs a better encapsulation and shellcheck isn't passing.
Maybe I should start another PR with the current install.sh. What are your thoughts? (I'd still need to update the other PR afterward, but that's not a problem)

This would be the base for improvements if any needed. Would the future be like prompt user questions to customize Coolify from first install (express install or advanced?) or just a 1-click install and then user customize later at ui...

@peaklabs-dev
Copy link
Member

peaklabs-dev commented Nov 12, 2024

Yes, I would start a new PR. Making the script non-interactive by default so everything is automatic by default would be ideal but if a user wants he can choose advanced where he can for example set a username, maybe even password and email for the web interface and a domain so the user does not have to add credentials over http. A new PR is great because we could merge that one and then only the other PR would need customization, which makes perfect sense.

Thanks for taking the time to contribute, I really like your PRs.

@peaklabs-dev
Copy link
Member

I would wait for the next version/ base of the current next branch as we made some changes. I will close this in favor of the new PR.

@github-actions github-actions bot removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants