-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Install Scripts #2733
Conversation
- Encapsulation - Added colors, logo, env vars flags - Shellcheck ok
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | GitHub App Keys | ccbbfd8 | database/seeders/GithubAppSeeder.php | View secret |
- | - | Generic Password | e1bcae7 | templates/compose/resend.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
A lot of things changed since then, so this needs to be reviewed @LEstradioto (sorry about that). |
@LEstradioto Is this still needed with the current install script? I know the other one to change the source dir is still open and needed. |
Yes, I think it still needs a better encapsulation and shellcheck isn't passing. This would be the base for improvements if any needed. Would the future be like prompt user questions to customize Coolify from first install (express install or advanced?) or just a 1-click install and then user customize later at ui... |
Yes, I would start a new PR. Making the script non-interactive by default so everything is automatic by default would be ideal but if a user wants he can choose advanced where he can for example set a username, maybe even password and email for the web interface and a domain so the user does not have to add credentials over http. A new PR is great because we could merge that one and then only the other PR would need customization, which makes perfect sense. Thanks for taking the time to contribute, I really like your PRs. |
I would wait for the next version/ base of the current next branch as we made some changes. I will close this in favor of the new PR. |
THIS IS SUPPOSED TO BE A MERGE AFTER #2710
I was working on #2710 and thought that a more readable and testable
install.sh
would be nice. This is a starting point that would facilitate further changes.Changes made: