-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for secure Redis (TLS support) #5526
Changes from 4 commits
5682ead
165075d
8ec2c90
7acd5a4
3d889e6
e65ce78
1f785bd
f0da061
ad008e9
c8fb4a1
78fe32d
94afb9d
757fcc4
004e8bc
cddfa6c
2a650c7
50e81a0
2fd6857
d35d223
ac46455
1677f1a
5bd94d5
c937297
34c8a4d
f50f1ea
a2f1012
a3e62f6
2b02cd2
a839300
599943d
e6e1612
fb2b682
345ed77
afaca1d
ba1639b
92a0fdc
3880417
9e24300
8cf6e72
ef5fc4e
5d35f50
7d0c504
a5ed0d9
648a346
819ae7b
f4dc404
a893259
8ba8f57
bb8090d
283be39
77ed234
afae18e
c667d42
5d396be
0281d71
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,14 @@ Run these commands to deploy the project to Heroku: | |
|
||
# Note: this is not a free plan | ||
heroku addons:create heroku-postgresql:essential-0 | ||
|
||
heroku addons:create heroku-redis:mini | ||
|
||
# Enable Redis TLS support (required for new Heroku Redis instances) | ||
heroku config:set REDIS_SSL=True | ||
heroku config:set CELERY_BROKER_USE_SSL=True | ||
heroku config:set CELERY_REDIS_BACKEND_USE_SSL=True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's put it after the existing line, please
browniebroke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# On Windows use double quotes for the time zone, e.g. | ||
# heroku pg:backups schedule --at "02:00 America/Los_Angeles" DATABASE_URL | ||
heroku pg:backups schedule --at '02:00 America/Los_Angeles' DATABASE_URL | ||
|
@@ -58,6 +66,11 @@ Run these commands to deploy the project to Heroku: | |
Notes | ||
----- | ||
|
||
Redis Configuration | ||
+++++++++++++++++++ | ||
|
||
Heroku Redis now requires TLS connections by default. The script above includes the necessary TLS configuration. These settings are optional and default to False, so they won't affect existing deployments unless explicitly enabled. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for this. While it seems like an important information right now, in month+ time, it will be irrelevant, so I'd rather not have this part in our docs |
||
|
||
Email Service | ||
+++++++++++++ | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -283,6 +283,9 @@ | |||||||||
} | ||||||||||
|
||||||||||
REDIS_URL = env("REDIS_URL", default="redis://{% if cookiecutter.use_docker == 'y' %}redis{%else%}localhost{% endif %}:6379/0") | ||||||||||
CELERY_BROKER_USE_SSL = env.bool("CELERY_BROKER_USE_SSL", default=False) | ||||||||||
CELERY_REDIS_BACKEND_USE_SSL = env.bool("CELERY_REDIS_BACKEND_USE_SSL", default=False) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can simplify things?
Suggested change
|
||||||||||
|
||||||||||
|
||||||||||
{% if cookiecutter.use_celery == 'y' -%} | ||||||||||
# Celery | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's already present at line 30