Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hint for UserFactory #5312

Merged

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Aug 21, 2024

Description

Since factory-boy 3.3.1, we can type annotate factories:

FactoryBoy/factory_boy#1059

Setting that up for the only factory of the project

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option): rely on existing mypy test
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Demonstrate best practice as part of the project

Since factory-boy 3.3.1, we can type annotate factories:

FactoryBoy/factory_boy#1059

Setting that up for the only factory of the project
Copy link
Collaborator

@foarsitter foarsitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@browniebroke browniebroke merged commit 6992738 into cookiecutter:master Aug 21, 2024
14 checks passed
@browniebroke browniebroke deleted the type-annotate-factories branch August 21, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants