Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing extra_body block in allauth entrance.html #5308

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add missing extra_body block in allauth entrance.html #5308

merged 1 commit into from
Aug 20, 2024

Conversation

milvagox
Copy link

@milvagox milvagox commented Aug 19, 2024 •
edited
Loading

Description

Adding extra_block block into /templates/allauth/layouts/entrance.html

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

django-allauth's WebAuthn MFA option is not working because extra_body block is missing. The block has JavaScript required.

@luzfcb luzfcb changed the title Fix missing extra_body block in allauth entrance.html Add missing extra_body block in allauth entrance.html Aug 20, 2024
@luzfcb
Copy link
Collaborator

luzfcb commented Aug 20, 2024

@milvagox Nice catch! Thanks

@luzfcb luzfcb merged commit 8af7634 into cookiecutter:master Aug 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luzfcb luzfcb luzfcb approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milvagox @luzfcb @browniebroke @jtmy