Handle Zip files on upload #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorgerhardt
force-pushed
the
use-files-directly
branch
from
0467676
to
c7317e1
Compare
trevorgerhardt
force-pushed
the
allow-zip-uploads
branch
from
e768117
to
e81b869
Compare
trevorgerhardt
force-pushed
the
use-files-directly
branch
from
c7317e1
to
7ff4bd0
Compare
trevorgerhardt
force-pushed
the
allow-zip-uploads
branch
from
e81b869
to
9a37304
Compare
trevorgerhardt
force-pushed
the
allow-zip-uploads
branch
from
be30db0
to
ea820c1
Compare
trevorgerhardt
added
t1
We use Apache FileUpload to assist with handling incoming files. We also use a DiskItemFactory that persists each incoming file to disk immediately. This means that we could represent each incoming file as a java.io.File instead of a FileItem. java.io.File is a much more common way of handling a file and easier to work with.
trevorgerhardt
force-pushed
the
use-files-directly
branch
from
d3e4a8f
to
7cd21db
Compare
Extract them into their individual files before handling like normal files. Refactors all controllers that handle file uploads to use the new utilities.
trevorgerhardt
force-pushed
the
allow-zip-uploads
branch
from
3f716b1
to
5135b22
Compare
trevorgerhardt
force-pushed
the
use-files-directly
branch
from
7cd21db
to
b0e72e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract zips into their individual files before handling. Refactors controllers that handle file uploads to use the new utilities.