Use pixel centers as points in web Mercator grids #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simpson desert tests are failing, which is not surprising as travel times are slightly different with this linking strategy. PR #896 changes those tests so they no longer depend on the position of the destination grid. That PR will need to be merged before this one's tests will pass. |
This was referenced Oct 18, 2023
All other uses of pixel edge functions now seem to be only for finding bounds of pixels, the entire grid, or extents. Point positions should now be uniformly in the center of Mercator pixels.
abyrd
force-pushed
the
mercator-pixel-center
branch
from
3b769bb
to
f23b3fc
Compare
abyrd
changed the base branch from
wgs-mercator-stability
to
merge-pixel-functions
abyrd
added
the
nv-update
|
Tests are now passing with the Simpson Desert test changes merged in. I think this is ready for final review. |
trevorgerhardt
previously approved these changes
Nov 2, 2023
|
@trevorgerhardt merge commit to combine the use of extents with pixelToCenterX invalidated your review. |
trevorgerhardt
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travel time and accessibility results will be slightly different when computed with workers after this change. Pre-built linkages in saved networks will not be affected - the entire network must be rebuilt to ensure they are consistent, so this requires a network version bump. However we are also updating to Kryo 5 serialization format, so if both changes are introduced at once in a release we need only bump the network version number once.