Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths recording refactor #835

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Paths recording refactor #835

wants to merge 21 commits into from

Commits on Sep 22, 2022

  1. Paths: return machine usable results 

    Returns times in seconds instead of converting before sending.
    @trevorgerhardt
    trevorgerhardt committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    743d879 View commit details
    Browse the repository at this point in the history

  2. Improve stopString and routeString outputs 

    If we are returning a single string, concatenating values can be very redundant as IDs may be the same as `short_name`s and stop indexes would need to be parsed to be useful.
    @trevorgerhardt
    trevorgerhardt committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    cd950c9 View commit details
    Browse the repository at this point in the history

  3. Round the minutes in the SimpsonDesertTests 

    Should the tests be using the "HumanReadableIteration" results?
    @trevorgerhardt
    trevorgerhardt committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    0ed82ea View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Merge branch 'dev' into path-summaries

    @trevorgerhardt
    trevorgerhardt committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    12c1e39 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Refactor paths recording 

    Refactor code around paths recording.
- Reduce flags and settings from peppering inner loops
- Consolidate regional / taui / single point recording
- Reduce code with "side effects" preferring methods that act on passed in data
- Modify single point path summaries to produce what the front-end will display.
    @trevorgerhardt
    trevorgerhardt committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    65f0eb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Add a PathResultSummary class 

    Translate a path result to data usable by the client side.
    @trevorgerhardt
    trevorgerhardt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4d3600b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'path-summaries' into paths-refactor

    @trevorgerhardt
    trevorgerhardt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    936914f View commit details
    Browse the repository at this point in the history

  3. Remove now unused HumanReadableIteration

    @trevorgerhardt
    trevorgerhardt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cf33d90 View commit details
    Browse the repository at this point in the history

  4. Clean up comments

    @trevorgerhardt
    trevorgerhardt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ad5269a View commit details
    Browse the repository at this point in the history

  5. Check for path result values before summarizing

    @trevorgerhardt
    trevorgerhardt committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c17c0bb View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Revert changes to TransitLayer and RouteSequence

    @trevorgerhardt
    trevorgerhardt committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    6652105 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Update field names to include seconds

    @trevorgerhardt
    trevorgerhardt committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    39a309a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'path-summaries' into paths-refactor

    @trevorgerhardt
    trevorgerhardt committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9f22a23 View commit details
    Browse the repository at this point in the history

  3. Remove unused methods

    @trevorgerhardt
    trevorgerhardt committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    219b262 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Additional clean up

    @trevorgerhardt
    trevorgerhardt committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    8183417 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Allow getPathResults to return null

    @trevorgerhardt
    trevorgerhardt committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7391d25 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into paths-refactor

    @trevorgerhardt
    trevorgerhardt committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    44b81f0 View commit details
    Browse the repository at this point in the history

  3. Use static creation method

    @trevorgerhardt
    trevorgerhardt committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    95cb044 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Move the propagater into analyst 

    - Remove the static initialize method from `PathResultsRecorder`
- Move the `summarize` method from `PathResult` -> `RegionalPathResultSummar`
    @trevorgerhardt
    trevorgerhardt committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9490c4a View commit details
    Browse the repository at this point in the history

  2. Rename parameter

    @trevorgerhardt
    trevorgerhardt committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    52d99ad View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Merge branch 'dev' into paths-refactor

    @trevorgerhardt
    trevorgerhardt committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    13c5b5a View commit details
    Browse the repository at this point in the history