Skip to content

Commit

Permalink
add comment explaining reason for recent patch
Browse files Browse the repository at this point in the history
  • Loading branch information
abyrd committed Nov 22, 2023
1 parent 6b41035 commit 484b53d
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ public abstract class CsvResultWriter extends BaseResultWriter implements Region
*/
public abstract CsvResultType resultType ();

/** Override to provide column names for this CSV writer. */
/**
* Override to provide column names for this CSV writer.
* NOTE: Due to Java weirdness, subclass implementations of this method will be called by the CsvResultWriter
* constructor at a time when fields of the subclass remain initialized, but uninitialized final primitive
* fields are still readable! Do not read subclass fields in these implementations until/unless this is restructured.
*/
protected abstract String[] columnHeaders ();

/** Override to extract row values from a single origin result. */
Expand Down

0 comments on commit 484b53d

Please sign in to comment.