-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic markdown template #70
base: master
Are you sure you want to change the base?
Conversation
import numpy as np | ||
import matplotlib.pyplot as plt | ||
xmin = np.linspace(0.01, 3, 30) | ||
# TODO changing 0.01 to 0 above results in an error -- suspected GPkit bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to remove_unbounded_zeros
to use a <= 0
constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true - good point
responded to code review. |
@@ -18,8 +18,7 @@ The full GP, derived from the Python implementation of the model, is | |||
from simple_gp import SimpleGP | |||
m = SimpleGP() | |||
with open("gp.generated.tex", "w") as f: | |||
f.write(m._repr_latex_()) | |||
# TODO wish model name didn't get printed in the above | |||
f.write("$%s$" % m.latex(excluded=["models", "units"])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bqpd note the need for dollar signs here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
Looks good to me! Do we want any tests? |
@whoburg, I think this is ready to merge? |
@mjburton11, you've been using markdown a lot. Do you see any improvements that could be made to this template before we merge? (e.g. maybe your Let's all start new projects from this template and hopefully thereby make it better over time. |
Just added |
\begin{figure}[h!] | ||
\label{fig:sweep} | ||
\begin{center} | ||
\includegraphics{simple_sweep.pdf} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjburton11 is tackling convexengineering/gpkit#890, and then this should be good to merge |
@bqpd, please review and add additional commits if you see ways to improve