Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qstr #145

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Qstr #145

wants to merge 7 commits into from

Conversation

nillst
Copy link
Contributor

@nillst nillst commented Dec 7, 2017

a small tool for parsing GPkit quantities into formatted strings with units for easier display (eg on dashboards)

@bqpd
Copy link
Contributor

bqpd commented Dec 7, 2017

@nillst I made some changes for readability, lmk what you think!

@bqpd
Copy link
Contributor

bqpd commented Dec 7, 2017

add to whitelist

@bqpd
Copy link
Contributor

bqpd commented Dec 7, 2017

this this please

Copy link
Contributor

@bqpd bqpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bqpd
Copy link
Contributor

bqpd commented Jan 4, 2018

test models please

@bqpd
Copy link
Contributor

bqpd commented Jan 4, 2018

@nillst merge whenever you want :) sorry for the delay in review!

… into qstr

Updates to qstr branch before pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants