Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-lumo-styles): style details elements #432

Closed
wants to merge 1 commit into from
Closed

feat(cxl-lumo-styles): style details elements #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/cxl-lumo-styles/scss/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,3 +366,17 @@ body.theme-conversionxl-better {
font-size: var(--lumo-font-size-l);
}
}

/**
* Add spacing and typography styles to details and summary elements
* @see https://cxlworld.slack.com/archives/C01HXU5GGJG/p1724673491752389
* @since 2024.08.26
*/
details {
Copy link

@lkraav lkraav Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, are we not able to build a quick block editor details -> vaadin-details element converter instead, in spirit of https://github.com/conversionxl/cxl-section-block

Itmw, this type of native element CSS patch could go into both apps Customizer.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today we'll use ITMW approach but created a task for the future: https://app.clickup.com/t/86b1wx7r9

margin: var(--lumo-space-m) 0;

summary {
font-weight: 900;
margin-bottom: var(--lumo-space-s);
}
}
Loading