Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): cxl-inline-notification add component #414

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented May 16, 2024

@anoblet anoblet requested review from lkraav and pawelkmpt May 16, 2024 15:22
@anoblet anoblet force-pushed the anoblet/feat/inline-notification branch from 158ff40 to 7a89794 Compare May 16, 2024 15:22
Copy link

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.16 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.95 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 138.23 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 276.19 KB (+0.2% 🔺)

@anoblet anoblet force-pushed the anoblet/feat/inline-notification branch from 7a89794 to 4a7a139 Compare May 17, 2024 12:11
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component is not included in the index-institute.js.

It looks good on desktop but lacks paddings on smaller screens.

Screenshot 2024-08-01 at 10 23 40
Screenshot 2024-08-01 at 10 24 06
Screenshot 2024-08-01 at 10 24 17

@anoblet anoblet force-pushed the anoblet/feat/inline-notification branch 2 times, most recently from 56b3639 to c1d1348 Compare August 2, 2024 13:17
@anoblet
Copy link
Collaborator Author

anoblet commented Aug 2, 2024

I added a small vertical padding, and large horizontal padding.

image

@anoblet anoblet requested a review from pawelkmpt August 2, 2024 13:17
@pawelkmpt pawelkmpt force-pushed the anoblet/feat/inline-notification branch from c1d1348 to 2e6422c Compare August 8, 2024 08:54
@pawelkmpt
Copy link

It was slightly better but didn't look good on all screen sizes. Also component was not included in the index file, nor branch rebased on top of master...

I corrected these things myself.

@pawelkmpt pawelkmpt merged commit 31b894c into master Aug 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants