Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cxl-ui): add missing card hover styles #343

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix(cxl-ui): add missing card hover styles #343

merged 2 commits into from
Oct 13, 2023

Conversation

freudFlintstone
Copy link

@freudFlintstone freudFlintstone self-assigned this Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 63.56 KB (+0.13% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.65 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.81 KB (+0.04% 🔺)

@freudFlintstone freudFlintstone force-pushed the raphael/fix/dashboard/cards branch from 15e73c4 to b4a4fa3 Compare October 12, 2023 03:58
pawelkmpt
pawelkmpt reviewed Oct 12, 2023
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minidegree card link needs different color

Screenshot 2023-10-12 at 06 31 52

@HenerHoop HenerHoop force-pushed the raphael/fix/dashboard/cards branch from b4a4fa3 to e5c2747 Compare October 12, 2023 07:18
@freudFlintstone freudFlintstone force-pushed the raphael/fix/dashboard/cards branch from 8105283 to 4fa04a9 Compare October 12, 2023 18:23
pawelkmpt
pawelkmpt requested changes Oct 12, 2023
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change commit message for e5c2747
- fix(cxl-ui): add missing card hover styles
+ fix(cxl-ui): cxl-base-card, cxl-course-card add missing hover styles
  1. Squash 18a9e2b and 4fa04a9
  1. Squashed commit
  • move hover styles to commit 1
  • change commit message
- fix(cxl-ui): fix card size issues, remove CTA underline
+ fix(cxl-ui): cxl-course-card reduce height to 280px

@freudFlintstone freudFlintstone force-pushed the raphael/fix/dashboard/cards branch from 4fa04a9 to 3111d26 Compare October 12, 2023 19:52
@pawelkmpt pawelkmpt merged commit 6377a89 into master Oct 13, 2023
4 checks passed
@pawelkmpt pawelkmpt deleted the raphael/fix/dashboard/cards branch October 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

@anoblet anoblet Awaiting requested review from anoblet

Assignees

@freudFlintstone freudFlintstone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freudFlintstone @pawelkmpt